Fixed bug in bulk loader and changed function arugment in cutom tablres

tripal_bulk_loader/tripal_bulk_loader.loader.inc

@@ -806,7 +806,8 @@ function tripal_bulk_loader_add_foreignkey_to_values($table_array, $values, $dat
       // check to see if we have any default values in the $default_data array
       // these were populated from select statements that only need to run once
       // so we can reuse the values from those previous selects.
-      if (array_key_exists('values_default', $default_data[$foreign_priority]) and
+      if (array_key_exists($foreign_priority, $default_data) and
+          array_key_exists('values_default', $default_data[$foreign_priority]) and
           array_key_exists($foreign_field, $default_data[$foreign_priority]['values_default'])) {
          $values[$field] = $default_data[$foreign_priority]['values_default'][$foreign_field];
          continue;

tripal_core/includes/custom_tables.php

@@ -29,7 +29,7 @@
  *
  * @ingroup tripal_custom_tables_api
  */
-function tripal_core_edit_custom_table($table_id, $table_name, $schema, $skip_creation = 0) {
+function tripal_core_edit_custom_table($table_id, $table_name, $schema, $skip_creation = 1) {
 
   // Create a new record
   $record = new stdClass();
@@ -41,7 +41,7 @@ function tripal_core_edit_custom_table($table_id, $table_name, $schema, $skip_cr
   $sql = "SELECT * FROM {tripal_custom_tables} WHERE table_id = %d";
   $custom_table = db_fetch_object(db_query($sql, $table_id));
 
-  // drop the table from chado if it exists
+  // if skip creation is not set, then drop the table from chado if it exists
   if(!$skip_creation){
     if (db_table_exists($custom_table->table_name)) {
       chado_query("DROP TABLE %s", $custom_table->table_name);
@@ -88,29 +88,38 @@ function tripal_core_edit_custom_table($table_id, $table_name, $schema, $skip_cr
  * @param $schema
  *   A Drupal-style Schema API definition of the table
  * @param $skip_creation
- *   Set as TRUE to skip dropping and re-creation of the table.  This is
+ *   Set as TRUE to skip dropping and re-creation of the table if it already
- *   useful if the table was already created through another means and you
+ *   exists.  This is useful if the table was already created through another 
- *   simply want to make Tripal aware of the table schema.
+ *   means and you simply want to make Tripal aware of the table schema.  If the
+ *   table does not exist it will be created.
  *
  * @return
  *   A database query result resource for the new table, or FALSE if table was not constructed.
  *
  * @ingroup tripal_custom_tables_api
  */
-function tripal_core_create_custom_table(&$ret, $table, $schema, $skip_creation = 0) {
+function tripal_core_create_custom_table(&$ret, $table, $schema, $skip_creation = 1) {
   $ret = array();
     
-  // see if the table entry already exists
+  // see if the table entry already exists in the tripal_custom_tables table.
   $sql = "SELECT * FROM {tripal_custom_tables} WHERE table_name = '%s'";
   $centry = db_fetch_object(db_query($sql, $table));
   
-  // If the table exits in Chado but not in the tripal_custom_tables field
+  // check to see if the table already exists in the chado schema  
-  // then call an error.  if the table exits in the tripal_custom_tables but
-  // not in Chado then create the table and replace the entry.  
   $previous_db = tripal_db_set_active('chado');  // use chado database
   $exists = db_table_exists($table);
   tripal_db_set_active($previous_db);  // now use drupal database
 
+  // if the table exists but we have no record for it in the tripal_custom_tables
+  // table then raise an error.
+  if ($exists and !$centry) {
+    watchdog('tripal_core', "Could not add custom table '!table_name'. It ".
+            "already exists but is not known to Tripal as being a custom table.",
+      array('!table_name' => $table), WATCHDOG_WARNING);
+    return FALSE;
+  }
+  
+  // if the table does not exist then create it
   if (!$exists) {
     $previous_db = tripal_db_set_active('chado');  // use chado database
     db_create_table($ret, $table, $schema);
@@ -120,13 +129,10 @@ function tripal_core_create_custom_table(&$ret, $table, $schema, $skip_creation
         array('!table_name' => $table), WATCHDOG_ERROR);
       return FALSE;
     }
-  }
+  }  
-  if ($exists and !$centry and !$skip_creation) {
+
-    watchdog('tripal_core', "Could not add custom table '!table_name'. It ".
+  // if the table exists in Chado and in our custom table and
-            "already exists but is not known to Tripal as being a custom table.",
+  // skip creation is turned off then drop and re-create the table
-      array('!table_name' => $table), WATCHDOG_WARNING);
-    return FALSE;
-  }
   if ($exists and $centry and !$skip_creation) {
     // drop the table we'll recreate it with the new schema
     $previous_db = tripal_db_set_active('chado');  // use chado database
@@ -315,13 +321,14 @@ function tripal_custom_tables_form(&$form_state = NULL, $table_id = NULL) {
     // form_state then let's use that, otherwise, we'll pull
     // the values from the database
     $default_schema = $form_state['values']['schema'];
-    $default_skip = $form_state['values']['skip_creation'];
+    $default_force_drop = $form_state['values']['force_drop'];
 
     if (!$default_table_name) {
       $default_table = $custom_table->table_name;
     }
     if (!$default_schema) {
       $default_schema = var_export(unserialize($custom_table->schema),1);
+      $default_schema = preg_replace('/=>\s+\n\s+array/','=> array', $default_schema);
     }
   }
 
@@ -341,20 +348,19 @@ function tripal_custom_tables_form(&$form_state = NULL, $table_id = NULL) {
     '#value'         => t('At times it is necessary to add a custom table to the Chado schema.  
        These are not offically sanctioned tables but may be necessary for local data requirements.  
        Avoid creating custom tables when possible as other GMOD tools may not recognize these tables
-       nor the data in them.  Linker tables are often a good candidate for
+       nor the data in them.  Linker tables or property tables are often a good candidate for
-       a custom table. For example a table to link stocks and libraries (e.g. library_stock).  If the
+       a custom table. For example a table to link stocks and libraries (e.g. library_stock) would be
-       table already exists it will be dropped and re-added using the definition supplied below. All 
+       a good custom table. Try to model linker or propery tables after existing tables.  If the
-       data in the table will be lost.  However, If you
+       table already exists it will not be modified.  To force dropping and recreation of the table
-       are certain the schema definition you provide is correct for an existing table, select the checkbox
+       click the checkbox below.
-       below to skip creation of the table.
     '),
   );
 
-  $form['skip_creation']= array(
+  $form['force_drop']= array(
     '#type'          => 'checkbox',
-    '#title'         => t('Skip Table Creation'),
+    '#title'         => t('Re-create table'),
-    '#description'   => t('If your table already exists, check this box to prevent it from being dropped and re-created.'),
+    '#description'   => t('Check this box if your table already exists and you would like to drop it and recreate it.'),
-    '#default_value' => $default_skip,
+    '#default_value' => $default_force_drop,
   );
   $form['schema']= array(
     '#type'          => 'textarea',
@@ -474,13 +480,19 @@ function tripal_custom_tables_form_submit($form, &$form_state) {
   $action = $form_state['values']['action'];
   $table_id = $form_state['values']['table_id'];
   $schema = $form_state['values']['schema'];
-  $skip_creation = $form_state['values']['skip_creation'];
+  $force_drop = $form_state['values']['force_drop'];
+  
+  $skip_creation = 1;
+  if ($force_drop) {
+     $skip_creation = 0;
+  }
 
   // conver the schema into a PHP array
   $schema_arr = array();
   eval("\$schema_arr = $schema;");
+  
 
-  if (strcmp($action, 'Edit') == 0) {
+  if (strcmp($action, 'Edit') == 0) {  	
     tripal_core_edit_custom_table($table_id, $schema_arr['table'], $schema_arr, $skip_creation);
   }
   elseif (strcmp($action, 'Add') == 0) {